Page 1 of 1

DownloadUpdates.cmd copy-paste-error

PostPosted: 13.01.2018, 21:43
by SoniShyam
Dear Sir,
While studying the DownloadUpdates.cmd script, i am in doubt. The line number 1067 & 1074 is very similar (just copy). I think, the line number 1074 should use "HideList-seconly.txt" instead of "ExcludeList-superseded.txt".

Thanks.

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 13.01.2018, 23:21
by aker
Seems correct.

We'll fix that in the next update.

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 14.01.2018, 00:31
by harry
No!

The code works as intended:

If wsusscn2.cab has changed (line 1058) or if ExcludeList-superseded-exclude.txt has changed (line 1065) or if HideList-seconly.txt has changed (line 1072), then ExcludeList-superseded.txt is not valid anymore and must be deleted.

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 14.01.2018, 05:44
by SoniShyam
Thanks all,

understood the logic, but on line number 1199 with kind of files being referenced by %3 i.e.

if exist ..\static\StaticDownloadLinks-%1-%3-%2.txt

which file referenced by %3 when %3 is always begins with / character

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 15.01.2018, 15:23
by WSUSUpdateAdmin
Hi.

Sorry, I don't understand what you mean.

Line 1199 is part of the "DownloadCore" subroutine starting at line 1027 and called by

Code: Select all
654: call :DownloadCore dotnet %TARGET_ARCH%-glb %TARGET_ARCH% %SKIP_PARAM%
695: call :DownloadCore dotnet %TARGET_ARCH%-glb %TARGET_ARCH% %SKIP_PARAM%
998: call :DownloadCore win glb x86 /skipdynamic
1005: call :DownloadCore ofc %2 %TARGET_ARCH% %SKIP_PARAM%
1007: call :DownloadCore %1 glb %TARGET_ARCH% %SKIP_PARAM%
1009: call :DownloadCore %1 %2 %TARGET_ARCH% %SKIP_PARAM%
1015: call :DownloadCore %1 glb %TARGET_ARCH% %SKIP_PARAM%
1021: call :DownloadCore %1 %2 %TARGET_ARCH% %SKIP_PARAM%

..., where %3 always gives the target architecture, not '/'.

Regards
T. Wittrock

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 20.01.2018, 01:18
by aker
I should really stop reviewing code in night.

Re: DownloadUpdates.cmd copy-paste-error

PostPosted: 22.01.2018, 15:51
by WSUSUpdateAdmin
;)
Don't worry!