dotnet-x86 and dotnet-x64 hashes

[boco]

There's still an issue with either one of these hashes being deleted when they shouldn't be. Note that from my observations, both these are checked (and now deleted?) BEFORE the 'same day rule' kicks in.

@WSUSAdmin: Could you risk a look on the code lines in question? Shouldn't the dotnet-x??.txt hashes only be processed when the 'same day rule' doesn't apply?

[WSUSUpdateAdmin]

Thanks, boco, I will - tomorrow.
Greets
Torsten

[WSUSUpdateAdmin]

Hi boco,

could you please be a bit more precise explaining the misbehaviour you recognized?

Actually, I had a (quick) review of DownloadUpdates.cmd lines 503-526:

Code: Select all

if exist ..\client\md\hashes-dotnet.txt (
  echo Verifying integrity of .NET Frameworks' installation files...
  pushd ..\client\md
  ..\bin\%HASHDEEP_EXE% -a -l -vv -k hashes-dotnet.txt ..\dotnet\dotnetfx*.exe
  if errorlevel 1 (
    popd
    goto IntegrityError
  )


Break on audit failure

Code: Select all

  popd
  echo %DATE% %TIME% - Info: Verified integrity of .NET Frameworks' installation files >>%DOWNLOAD_LOGFILE%
  if exist ..\client\md\hashes-dotnet-%TARGET_ARCH%-glb.txt (
    for %%i in (..\client\md\hashes-dotnet-%TARGET_ARCH%-glb.txt) do echo _%%~ti | %SystemRoot%\system32\find.exe "_%DATE:~-10%" >nul 2>&1
    if not errorlevel 1 (
      echo Skipping download/validation of .NET Frameworks' files ^(%TARGET_ARCH%^) due to 'same day' rule.
      echo %DATE% %TIME% - Info: Skipped download/validation of .NET Frameworks' files ^(%TARGET_ARCH%^) due to 'same day' rule >>%DOWNLOAD_LOGFILE%
      goto SkipDotNet
    )
  )


Audit passed, "same day rule" applied, no hash file deletion

Code: Select all

  del ..\client\md\hashes-dotnet.txt
  if exist ..\client\md\hashes-dotnet-%TARGET_ARCH%-glb.txt del ..\client\md\hashes-dotnet-%TARGET_ARCH%-glb.txt
) else (
  echo Warning: Integrity database ..\client\md\hashes-dotnet.txt not found.
  echo %DATE% %TIME% - Warning: Integrity database ..\client\md\hashes-dotnet.txt not found >>%DOWNLOAD_LOGFILE%
)


Audit passed, "same day rule" didn't apply, hash files were deleted

As I read this, I can't see any problem yet.


Regards
Torsten Wittrock

[boco]

I just tested again. If the same day rule does NOT trigger, the hashes-dotnet-x??-glb.txt is deleted and then the error printer to the log...

I cannot find the line where the hashes-dotnet-x??-glb.txt files are actually CHECKED (before being deleted)? Maybe I'm just lost in the sources...

[boco]

Could you please point me to the line where the hashes-x??-glb.txt are checked? I only find the line for hashes-dotnet.txt...

The hashes-x??-glb.txt is deleted, and immediately after the WSUSOU complains it cannot be found. Genius...

[WSUSUpdateAdmin]

I see what you mean now:

Code: Select all

Warning: Integrity database ..\client\md\hashes-dotnet-x86-glb.txt not found.


Could you please point me to the line where the hashes-x??-glb.txt are checked? I only find the line for hashes-dotnet.txt...

Yes, it's in the core (line 906++), called at line 539, which I forgot.
Now I'll delete line 522 for revision 505.

The hashes-x??-glb.txt is deleted, and immediately after the WSUSOU complains it cannot be found. Genius...

Shit happens.
If people weren't making mistakes and producing bugs, neither MS patches nor this project would exist.

Regards
Torsten Wittrock

[boco]

WSUSOU still beats MS and the bitten fruit company when it comes to smashing bugs.