DownloadUpdates.cmd copy-paste-error

DownloadUpdates.cmd copy-paste-error

Postby SoniShyam » 13.01.2018, 21:43

Dear Sir,
While studying the DownloadUpdates.cmd script, i am in doubt. The line number 1067 & 1074 is very similar (just copy). I think, the line number 1074 should use "HideList-seconly.txt" instead of "ExcludeList-superseded.txt".

Thanks.
SoniShyam
 
Posts: 2
Joined: 13.01.2018, 19:21

Re: DownloadUpdates.cmd copy-paste-error

Postby aker » 13.01.2018, 23:21

Seems correct.

We'll fix that in the next update.
Wer Rechtschreibfehler findet, darf sie behalten oder an den Meistbietenden versteigern. / Everybody finding a misspelling is allowed to sell it.
aker
aker
 
Posts: 2897
Joined: 02.03.2011, 16:32

Re: DownloadUpdates.cmd copy-paste-error

Postby harry » 14.01.2018, 00:31

No!

The code works as intended:

If wsusscn2.cab has changed (line 1058) or if ExcludeList-superseded-exclude.txt has changed (line 1065) or if HideList-seconly.txt has changed (line 1072), then ExcludeList-superseded.txt is not valid anymore and must be deleted.
harry
 
Posts: 696
Joined: 29.10.2009, 18:02

Re: DownloadUpdates.cmd copy-paste-error

Postby SoniShyam » 14.01.2018, 05:44

Thanks all,

understood the logic, but on line number 1199 with kind of files being referenced by %3 i.e.

if exist ..\static\StaticDownloadLinks-%1-%3-%2.txt

which file referenced by %3 when %3 is always begins with / character
SoniShyam
 
Posts: 2
Joined: 13.01.2018, 19:21

Re: DownloadUpdates.cmd copy-paste-error

Postby WSUSUpdateAdmin » 15.01.2018, 15:23

Hi.

Sorry, I don't understand what you mean.

Line 1199 is part of the "DownloadCore" subroutine starting at line 1027 and called by

Code: Select all
654: call :DownloadCore dotnet %TARGET_ARCH%-glb %TARGET_ARCH% %SKIP_PARAM%
695: call :DownloadCore dotnet %TARGET_ARCH%-glb %TARGET_ARCH% %SKIP_PARAM%
998: call :DownloadCore win glb x86 /skipdynamic
1005: call :DownloadCore ofc %2 %TARGET_ARCH% %SKIP_PARAM%
1007: call :DownloadCore %1 glb %TARGET_ARCH% %SKIP_PARAM%
1009: call :DownloadCore %1 %2 %TARGET_ARCH% %SKIP_PARAM%
1015: call :DownloadCore %1 glb %TARGET_ARCH% %SKIP_PARAM%
1021: call :DownloadCore %1 %2 %TARGET_ARCH% %SKIP_PARAM%

..., where %3 always gives the target architecture, not '/'.

Regards
T. Wittrock
WSUSUpdateAdmin
Administrator
 
Posts: 2074
Joined: 07.07.2009, 15:38

Re: DownloadUpdates.cmd copy-paste-error

Postby aker » 20.01.2018, 01:18

I should really stop reviewing code in night.
Wer Rechtschreibfehler findet, darf sie behalten oder an den Meistbietenden versteigern. / Everybody finding a misspelling is allowed to sell it.
aker
aker
 
Posts: 2897
Joined: 02.03.2011, 16:32

Re: DownloadUpdates.cmd copy-paste-error

Postby WSUSUpdateAdmin » 22.01.2018, 15:51

;)
Don't worry!
WSUSUpdateAdmin
Administrator
 
Posts: 2074
Joined: 07.07.2009, 15:38


Return to Download

Who is online

Users browsing this forum: No registered users and 4 guests